show the device and bundle versions on update when verbose is enabled #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askpatrickw
suggested changes
Dec 28, 2020
circup.py
Outdated
| @@ -687,6 +687,12 @@ def update(all): # pragma: no cover | |||
| click.echo("Please indicate which modules you wish to update:\n") | |||
| for module in modules: | |||
| update_flag = all | |||
| if VERBOSE: | |||
| click.echo( | |||
| "device version:{} bundle version:{}".format( | |||
There was a problem hiding this comment.
How about a little white space since this is for people to read? Like this: "device version: {} bundle version: {}"
Updated to make the text a little nicer
makermelissa
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
I updated this. Based on the review by @askpatrickw and adding the requested change, I'm approving. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when --verbose is enabled, show the device version and bundle version during update